Fix #564, consolidate delete finalization code #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
Remove repetitive clearing of the global ID and unlocking global table and replace with common implementation in the idmap code. In addition to removing repeated logic, this makes deletion more like an inverse of creation, and provides a common/single point where additiona deletion-related logic can be added.
jphickey
force-pushed
the
fix-564-consolidate-delete
branch
from
6239c84
to
2cc7dc5
Compare
|
Note- commit just 2cc7dc5 corrects an unused variable issue reported by cppcheck. |
|
@klystron78 - FYI this is largely the same subject as your previous review of #541. However note that the return_code is indeed still checked, the objective here is to put the cleanup code inside a common function (in this case |
skliper
approved these changes
Aug 19, 2020
|
CCB 2020-08-19 APPROVED |
yammajamma
added
CCB:Approved
yammajamma
removed
the
CCB:Ready
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#567, Document CFE_ES_RunLoop increment task counter behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Remove repetitive clearing of the global ID and unlocking global table and replace with common implementation in the
idmap source file. In addition to removing repeated logic, this makes deletion more like an inverse of creation, and provides
a common/single point where additional deletion-related logic can be added.
Fixes #564
Testing performed
Build and sanity test CFE
Confirm all unit tests
Expected behavior changes
No impact to external API or behavior. Internal code consolidation only.
System(s) tested on
Ubuntu 20.04
Additional context
See also #540 and #532
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.